Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobspec: add support for destination partition to upstream block #20167

Merged
merged 1 commit into from
Mar 22, 2024
Merged

jobspec: add support for destination partition to upstream block #20167

merged 1 commit into from
Mar 22, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Mar 20, 2024

Adds support for specifying a destination Consul admin partition in the upstream block.

Fixes: #19785

@tgross tgross force-pushed the upstream-destination-admin-partition branch from 2ba58a9 to cc1293d Compare March 20, 2024 14:09
@tgross tgross added this to the 1.7.x milestone Mar 20, 2024
@tgross tgross added theme/consul type/enhancement theme/consul/connect Consul Connect integration backport/1.7.x backport to 1.7.x release line labels Mar 20, 2024
@tgross
jobspec: add support for destination partition to upstream block
7cab209 
Adds support for specifying a destination Consul admin partition in the
`upstream` block.

Fixes: #19785
@tgross tgross force-pushed the upstream-destination-admin-partition branch from cc1293d to 7cab209 Compare March 20, 2024 14:32
@tgross tgross marked this pull request as ready for review March 20, 2024 14:51
@tgross tgross mentioned this pull request Mar 21, 2024
Closed
gulducat
gulducat approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@gulducat gulducat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgross tgross merged commit bdf3ff3 into main Mar 22, 2024
21 checks passed
@tgross tgross deleted the upstream-destination-admin-partition branch March 22, 2024 20:15
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Mar 22, 2024
Merged
philrenaud pushed a commit that referenced this pull request Apr 18, 2024
@tgross @philrenaud
jobspec: add support for destination partition to upstream block (#…
a824e22 
…20167)

Adds support for specifying a destination Consul admin partition in the
`upstream` block.

Fixes: #19785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gulducat gulducat gulducat approved these changes

@Juanadelacuesta Juanadelacuesta Awaiting requested review from Juanadelacuesta

@angrycub angrycub Awaiting requested review from angrycub

Assignees
No one assigned
Labels
backport/1.7.x backport to 1.7.x release line theme/consul/connect Consul Connect integration theme/consul type/enhancement
Projects
None yet
Milestone
1.7.x
Development

Successfully merging this pull request may close these issues.

Consul Upstream Admin Partition Support
2 participants
@tgross @gulducat